-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MySQL/MariaDB: Use strict SQL mode #699
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the MySQL tests are failing rightfully, in the mysql-debug.log.xz
artifact, there are multiple occurrences of this error:
2024-03-18T12:28:52.624Z\tFATAL\ticingadb\tError 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1
And for the PostgreSQL tests, well, wait a few minutes, I'll create a PR, d'oh! 🙈
Here we go: |
For MySQL (and MariaDB, etc.), in addition to `ANSI_QUOTES` SQL mode, we now also set `TRADITIONAL`, which enables strict mode.
1adf3dc
to
16d43cb
Compare
Yeah, forgot to quote the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFTM!
For MySQL (and MariaDB, etc.), in addition to
ANSI_QUOTES
SQL mode, we now also setTRADITIONAL
, which enables strict mode.fixes #611
refs #624