Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account Redis' trademark policy #736

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Account Redis' trademark policy #736

merged 1 commit into from
Apr 11, 2024

Conversation

lippserd
Copy link
Member

@lippserd lippserd commented Apr 10, 2024 •
edited
Loading

@cla-bot cla-bot bot added the cla/signed label Apr 10, 2024
@lippserd lippserd added this to the 1.2.0 milestone Apr 10, 2024
@lippserd lippserd added the area/documentation Improvements or additions to documentation label Apr 10, 2024
@Al2Klimov Al2Klimov self-requested a review April 10, 2024 15:32
@Al2Klimov Al2Klimov marked this pull request as draft April 10, 2024 15:33
@Al2Klimov Al2Klimov self-assigned this Apr 10, 2024
@Al2Klimov
Copy link
Member

ImageOptim doesn't pay off – saves <1%. 👍

@Al2Klimov Al2Klimov marked this pull request as ready for review April 10, 2024 15:41
@Al2Klimov Al2Klimov removed their assignment Apr 10, 2024
Al2Klimov
Al2Klimov reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointing those folks to the door were also an option as the German law doesn't require this.

README.md Outdated Show resolved Hide resolved
config.example.yml Outdated
host: localhost

# Redis port.
# Defaults to '6380' since the Redis server provided by the 'icingadb-redis' package listens on that port.
# Host port.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Host port.
# TCP port.

doc/01-About.md Outdated Show resolved Hide resolved
doc/03-Configuration.md Outdated
| Option | Description |
|----------|--------------------------------------------------------------------------------------------------------------------------|
| host | **Required.** Host name or address, or absolute Unix socket path. |
| port | **Optional.** Host port. Defaults to `6380` matching the Redis® open source server port in the `icingadb-redis` package. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in config example.

julianbrost
julianbrost reviewed Apr 10, 2024
View reviewed changes
Copy link
Contributor

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh, I don't see why this PR should include whitespace changes completely unrelated places, even in files that would otherwise remain completely untouched.

doc/TRADEMARKS.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this file appear as a top-level menu entry in the menu of the documentation (i.e. left sidebar of https://icinga.com/docs/icinga-db/latest/)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope.

@lippserd
Copy link
Member Author

Tbh, I don't see why this PR should include whitespace changes completely unrelated places, even in files that would otherwise remain completely untouched.

Created a separate PR for the whitespace changes.

@julianbrost julianbrost mentioned this pull request Apr 11, 2024
Merged
julianbrost
julianbrost reviewed Apr 11, 2024
View reviewed changes
doc/04-Upgrading.md Outdated Show resolved Hide resolved
oxzi
oxzi reviewed Apr 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
julianbrost
julianbrost approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read this approval as "I don't have concerns about these changes". I don't know if those are necessary or sufficient, for that I don't understand enough legalese.

doc/images/icingadb-envs.png
Copy link
Contributor

@julianbrost julianbrost Apr 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt that the dimensions of this image were changed intentionally, but both icinga.com and GitHub show a scaled down version anyways, so that probably won't create any problems.

doc/images/icingadb-ha.png
Copy link
Contributor

@julianbrost julianbrost Apr 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for icingadb-envs.png.

@lippserd lippserd merged commit 7280916 into main Apr 11, 2024
31 checks passed
@lippserd lippserd deleted the redis-trademark branch April 11, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxzi oxzi oxzi left review comments

@Al2Klimov Al2Klimov Al2Klimov left review comments

@julianbrost julianbrost julianbrost approved these changes

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation cla/signed
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lippserd @Al2Klimov @julianbrost @oxzi