Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: Fix values to fit by increasing type sizes #779

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Jul 29, 2024

The icon_image_alt column in both the host and service tables contains an image alt text. However, because it is defined as a varchar(32), many alt texts do not fit. The type has been expanded to text, as with most free text fields.

Closes #752.

When defining a TimePeriod, the maximum length of a range value was capped at 255 characters. This limitation has now also been removed by switching to the Text type.

Closes #724.

While re-reading the schema, I stumbled upon some missing properties_checksum comments that were also added.

@oxzi oxzi added bug Something isn't working area/schema labels Jul 29, 2024
@oxzi oxzi requested a review from julianbrost July 29, 2024 13:27
@cla-bot cla-bot bot added the cla/signed label Jul 29, 2024
@julianbrost
Copy link
Contributor

You also have to change the schema version in the full schema files, this causes the tests to fail:

{"L":"DEBUG","T":"2024-07-29T13:28:45.972Z","M":"container output","icingadb":true,"container-name":"icinga-testing-23013c75-icingadb-1","container-id":"34ba7d25a68def80987e5409f44ee9fa245e70cb426c4ecda970b3f853d2b103","line":"2024-07-29T13:28:45.972Z\tFATAL\ticingadb\tunexpected database schema version: v3 (expected v4), please make sure you have applied all database migrations after upgrading Icinga DB"}

@oxzi oxzi force-pushed the schema-fixes-i724-i752 branch from b07d784 to af52e88 Compare July 29, 2024 15:22
@oxzi
Copy link
Member Author

oxzi commented Jul 29, 2024

Thanks @julianbrost, I was just debugging this and unfortunately missed this very message.

@julianbrost
Copy link
Contributor

I can highly recommend grep -i -e fatal -e panic as the very first action when checking these logs 😅

@oxzi oxzi added this to the 1.2.1 milestone Jul 30, 2024
The icon_image_alt column in both the host and service tables contains
an image alt text. However, because it is defined as a varchar(32), many
alt texts do not fit. The type has been expanded to text, as with most
free text fields.

Closes #752.

When defining a TimePeriod, the maximum length of a range value was
capped at 255 characters. This limitation has now also been removed by
switching to the Text type.

Closes #724.

While re-reading the schema, I stumbled upon some missing
properties_checksum comments that were also added.
@oxzi oxzi force-pushed the schema-fixes-i724-i752 branch from af52e88 to 27d27d4 Compare July 30, 2024 08:38
@julianbrost julianbrost merged commit 9cde14e into main Jul 31, 2024
31 checks passed
@julianbrost julianbrost deleted the schema-fixes-i724-i752 branch July 31, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/schema bug Something isn't working cla/signed
Projects
None yet
2 participants