IcingaArguments: be unmodified when loaded from db

fixes #2660
Icinga · Aug 21, 2023 · 8896e54 · 8896e54
1 parent 907d93e
commit 8896e54
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/doc/82-Changelog.md b/doc/82-Changelog.md
@@ -33,6 +33,9 @@ This version hasn't been released yet
 * FEATURE: CIDR notation (network ranges) is supported in such filters (#2757)
 * FIX: synchronizing Service (and -Set) Templates has been fixed (#2745, #2217)
 
+### REST API
+* FIX: Commands give 304 w/o ghost changes for same properties (#2660)
+
 ### Permissions and Restrictions
 * FIX: monitoring-related permission checks have been refactored (#2712)
 * FIX: Hostgroup-Filters have not been applied to Overview tables (#2775)

diff --git a/library/Director/Objects/IcingaArguments.php b/library/Director/Objects/IcingaArguments.php
@@ -296,6 +296,7 @@ protected function loadFromDb()
         $this->arguments = IcingaCommandArgument::loadAll($connection, $query, 'argument_name');
         $this->cloneStored();
         $this->refreshIndex();
+        $this->modified = false;
 
         return $this;
     }
@@ -360,6 +361,7 @@ public function setBeingLoadedFromDb()
         }
         $this->refreshIndex();
         $this->cloneStored();
+        $this->modified = false;
     }
 
     /**
@@ -393,7 +395,9 @@ public function store()
             unset($this->arguments[$key]);
         }
 
+        $this->refreshIndex();
         $this->cloneStored();
+        $this->modified = false;
 
         return $this;
     }