Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement REST API support for blacklisted hosts for inherited services #1726

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Implement REST API support for blacklisted hosts for inherited services #1726

wants to merge 4 commits into from

Conversation

mdetrano
Copy link
Contributor

@mdetrano mdetrano commented Dec 3, 2018

I would like to submit for consideration this pull request, which implements support for "blacklisted hosts", for host-template services, via the Rest API. It does this by returning or accepting a "blacklisted_hosts" array in the JSON data for service objects.

This modification is useful for cases where one wants to sync-up configurations or use external tools to add hosts to Director, and would like to take advantage of the recently-added feature to exclude some services from being inherited from host templates used by the host.

@mdetrano mdetrano force-pushed the api_support_blacklisted_hosts branch from b473df4 to e2eb47c Compare August 30, 2019 17:16
@mdetrano mdetrano force-pushed the api_support_blacklisted_hosts branch from 0c6b117 to 2efb6a7 Compare December 16, 2019 20:41
@mdetrano mdetrano force-pushed the api_support_blacklisted_hosts branch from 2efb6a7 to 7bdfdda Compare August 13, 2020 21:52
@mdetrano mdetrano force-pushed the api_support_blacklisted_hosts branch 2 times, most recently from 29621a0 to 5ec1c30 Compare December 16, 2020 18:46
@mdetrano mdetrano force-pushed the api_support_blacklisted_hosts branch 2 times, most recently from 7609cb5 to 2893f9f Compare July 12, 2021 22:18
@mdetrano mdetrano force-pushed the api_support_blacklisted_hosts branch from 2893f9f to effbf84 Compare January 20, 2022 00:12
@cla-bot
Copy link

cla-bot bot commented Jan 20, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: GMS System.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@mdetrano mdetrano force-pushed the api_support_blacklisted_hosts branch from effbf84 to 6b61df4 Compare February 23, 2022 21:10
@cla-bot
Copy link

cla-bot bot commented Feb 23, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: GMS System.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@mdetrano mdetrano force-pushed the api_support_blacklisted_hosts branch from 6b61df4 to cd20714 Compare March 22, 2022 21:38
@cla-bot
Copy link

cla-bot bot commented Mar 22, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: GMS System.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@mdetrano mdetrano force-pushed the api_support_blacklisted_hosts branch from cd20714 to 9db40a2 Compare April 19, 2022 17:51
@cla-bot
Copy link

cla-bot bot commented Apr 19, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: GMS System.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@mdetrano mdetrano force-pushed the api_support_blacklisted_hosts branch from 9db40a2 to ebbc02b Compare August 8, 2022 19:40
@cla-bot
Copy link

cla-bot bot commented Aug 8, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: GMS System.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@mdetrano mdetrano force-pushed the api_support_blacklisted_hosts branch from ebbc02b to d888abb Compare November 7, 2022 16:20
@cla-bot
Copy link

cla-bot bot commented Nov 7, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: GMS System.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@mdetrano mdetrano force-pushed the api_support_blacklisted_hosts branch from d888abb to e300108 Compare June 15, 2023 03:23
@cla-bot
Copy link

cla-bot bot commented Jun 15, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: GMS System.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Sep 26, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: GMS System.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@mdetrano mdetrano force-pushed the api_support_blacklisted_hosts branch from 56e1b57 to 8347e5c Compare November 10, 2023 20:09
@cla-bot cla-bot
Copy link

cla-bot bot commented Nov 10, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: GMS System.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@mdetrano mdetrano force-pushed the api_support_blacklisted_hosts branch from 8347e5c to a97eb92 Compare February 7, 2024 16:39
@cla-bot cla-bot
Copy link

cla-bot bot commented Feb 7, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: GMS System.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdetrano