Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the doc - PostgreSQL-part #2249

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ackbyte
Copy link

@ackbyte ackbyte commented Dec 8, 2020

Corrected the PostgreSQL statements, because of some typos.

Corrected the PostgreSQL statements, because of some typos.
@Thomas-Gelf
Copy link
Contributor

Thanks for your contribution, @ackbyte! What went wrong with the original code block, didn't that work for you?

@ackbyte
Copy link
Author

ackbyte commented Dec 8, 2020

Hi @Thomas-Gelf, there are multiple issues, that getting fixed by this pull request:

  1. faulty SQL-Statement syntax, which is not run able because of missing quotation marks
  2. mixing multiple execution styles of the statements. One from inside the psql-shell and the other one from the bash-shell

BR
ackbyte

@Thomas-Gelf
Copy link
Contributor

Did you try to paste the whole block at once?

@ackbyte
Copy link
Author

ackbyte commented Dec 8, 2020

@Thomas-Gelf, no. Because one part of the block is optional... as described in the documentation as an optional part.
So the whole block has also to be spitted to fit the description.

@Thomas-Gelf
Copy link
Contributor

IMHO we should better no longer state that it is "optional" :D Thanks for pointing me to this. Of course if you leave out part of the statement you are required to do so in a correct way. And having separate statements would obviously make it easier to do so. But apart from that, the original block should be correct - isn't it? Or do I miss something?

@ackbyte
Copy link
Author

ackbyte commented Dec 8, 2020

That's correct @Thomas-Gelf ;) When pgcrypto gets mandatory part - the origin block is correct and can be used as it is :)

@Thomas-Gelf
Copy link
Contributor

Thanks @ackbyte! I'll double-check this and then either merge your pull request or declare the "optional" part being required.

@cla-bot
Copy link

cla-bot bot commented Dec 9, 2021

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @ackbyte

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants