-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the doc - PostgreSQL-part #2249
base: master
Are you sure you want to change the base?
Conversation
Corrected the PostgreSQL statements, because of some typos.
Thanks for your contribution, @ackbyte! What went wrong with the original code block, didn't that work for you? |
Hi @Thomas-Gelf, there are multiple issues, that getting fixed by this pull request:
BR |
Did you try to paste the whole block at once? |
@Thomas-Gelf, no. Because one part of the block is optional... as described in the documentation as an optional part. |
IMHO we should better no longer state that it is "optional" :D Thanks for pointing me to this. Of course if you leave out part of the statement you are required to do so in a correct way. And having separate statements would obviously make it easier to do so. But apart from that, the original block should be correct - isn't it? Or do I miss something? |
That's correct @Thomas-Gelf ;) When pgcrypto gets mandatory part - the origin block is correct and can be used as it is :) |
Thanks @ackbyte! I'll double-check this and then either merge your pull request or declare the "optional" part being required. |
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @ackbyte
|
Corrected the PostgreSQL statements, because of some typos.