Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow macros with parameters #2446

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

v0tti
Copy link

@v0tti v0tti commented Dec 6, 2021

This fixes #2432 by adding a matchRegex parameter. It should not break any existing use cases and just allows for more flexibility when using "Apply For" rules.

@cla-bot
Copy link

cla-bot bot commented Dec 6, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Alexander Votteler.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@v0tti
Copy link
Author

v0tti commented Dec 6, 2021

I added the commit email address to my GitHub account, should be good now.

@nilmerg
Copy link
Member

nilmerg commented Dec 7, 2021

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Dec 7, 2021

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @v0tti

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@v0tti
Copy link
Author

v0tti commented Dec 7, 2021

I have signed the CLA now.
@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Dec 7, 2021

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @v0tti

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@bobapple
Copy link
Member

bobapple commented Dec 7, 2021

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for more then just $config$ in Service Apply For Rule properties
3 participants