Phpstan: Fix deprecated function param types #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
phpstan-max-level
branch
6 times, most recently
from
3e2bc46
to
933d3b7
Compare
sukhwinder33445
changed the title
sukhwinder33445
changed the title
nilmerg
reviewed
Jan 19, 2024
sukhwinder33445
force-pushed
the
phpstan-max-level
branch
from
933d3b7
to
7ba5c69
Compare
sukhwinder33445
commented
Jan 19, 2024
sukhwinder33445
force-pushed
the
phpstan-max-level
branch
4 times, most recently
from
e093392
to
61adac1
Compare
…param Php >= 8 returns CurlHandle instead of resource, which confuses phpstan.
nilmerg
force-pushed
the
phpstan-max-level
branch
from
61adac1
to
9cccd90
Compare
nilmerg
changed the title
nilmerg
approved these changes
Feb 5, 2024
This was
linked to
issues
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes:
#2827
#2819