Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhide imports from Choices when doing multiedit #2867

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arjanoosting
Copy link

When doing an multiedit the Choises are not shown but the corresponding Host templates are filtered from the imports.
And if you then do a save the imports are removed from the hosts. see issue #1203

This small patch unhides the filtered host templates when doing an multiedit.

The nicer solution is showing the choices as well in the multiedit, but that is much more complicated code change :)

Copy link

cla-bot bot commented Feb 8, 2024

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @arjanoosting

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@bobapple
Copy link
Member

bobapple commented Feb 8, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Feb 8, 2024
@lippserd
Copy link
Member

@raviks789 Please check this PR.

@raviks789
Copy link
Collaborator

@lippserd I'm not entirely sure I understand the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants