Fix sync rule preview in case of boolean properties #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raviks789
force-pushed
the
fix/sync-preview-with-bool-property
branch
from
861fb8e
to
bd3b324
Compare
raviks789
force-pushed
the
fix/sync-preview-with-bool-property
branch
2 times, most recently
from
98d2bcf
to
a8d8730
Compare
lippserd
approved these changes
Oct 28, 2024
|
@raviks789 Please write a summary about the issue in the PR description. |
lippserd
force-pushed
the
fix/sync-preview-with-bool-property
branch
from
a8d8730
to
4099622
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync rules created for import sources, importing objects with boolean properties, throws
SQLSTATEerror as shown in the screenshot below.The reason for this is because the preview creates temporary branched objects by importing the objects' properties to check for the modifications. And the boolean properties, were not transformed to
yorn(which is the supported datatype for boolean (ENUM('y','n')) to store in the database) before the temporary object is created.fixes ref/IP/53248