Skip to content

Commit

Permalink
Merge pull request #191 from Icinga/dop-compat-decorator
Browse files Browse the repository at this point in the history
Drop `CompatDecorator` & use form default decorator instead
  • Loading branch information
yhabteab authored Jul 12, 2023
2 parents 9d019d0 + bc9da11 commit 2e7b96b
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 74 deletions.
65 changes: 0 additions & 65 deletions library/Reporting/Web/Forms/Decorator/CompatDecorator.php

This file was deleted.

3 changes: 0 additions & 3 deletions library/Reporting/Web/Forms/ReportForm.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
use Icinga\Authentication\Auth;
use Icinga\Module\Reporting\Database;
use Icinga\Module\Reporting\ProvidedReports;
use Icinga\Module\Reporting\Web\Forms\Decorator\CompatDecorator;
use ipl\Html\Contract\FormSubmitElement;
use ipl\Html\Form;
use ipl\Validator\CallbackValidator;
Expand Down Expand Up @@ -73,8 +72,6 @@ public function hasBeenSubmitted(): bool

protected function assemble()
{
$this->setDefaultElementDecorator(new CompatDecorator());

$this->addElement('text', 'name', [
'required' => true,
'label' => $this->translate('Name'),
Expand Down
3 changes: 0 additions & 3 deletions library/Reporting/Web/Forms/SendForm.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
use Icinga\Module\Reporting\Database;
use Icinga\Module\Reporting\ProvidedReports;
use Icinga\Module\Reporting\Report;
use Icinga\Module\Reporting\Web\Forms\Decorator\CompatDecorator;
use ipl\Web\Compat\CompatForm;

class SendForm extends CompatForm
Expand All @@ -28,8 +27,6 @@ public function setReport(Report $report)

protected function assemble()
{
$this->setDefaultElementDecorator(new CompatDecorator());

(new SendMail())->initConfigForm($this, $this->report);

$this->addElement('submit', 'submit', [
Expand Down
3 changes: 0 additions & 3 deletions library/Reporting/Web/Forms/TemplateForm.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
use Exception;
use Icinga\Authentication\Auth;
use Icinga\Module\Reporting\Database;
use Icinga\Module\Reporting\Web\Forms\Decorator\CompatDecorator;
use ipl\Html\Contract\FormSubmitElement;
use ipl\Html\Html;
use ipl\Web\Compat\CompatForm;
Expand Down Expand Up @@ -54,8 +53,6 @@ public function hasBeenSubmitted(): bool

protected function assemble()
{
$this->setDefaultElementDecorator(new CompatDecorator());

$this->setAttribute('enctype', 'multipart/form-data');

$this->add(Html::tag('h2', 'Template Settings'));
Expand Down

0 comments on commit 2e7b96b

Please sign in to comment.