Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form submit handling #81

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Form submit handling #81

wants to merge 9 commits into from

Commits on Oct 20, 2022

  1. Remove event Form::ON_SENT

    @lippserd
    lippserd committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    f131d12 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Introduce Form::onSubmit(FormSubmitElement) and ::ON_SUBMIT 

    Considers form submitted when one of its submit elements has been
pressed.
    @lippserd
    lippserd committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    154caf1 View commit details
    Browse the repository at this point in the history

  2. Respect formnovalidate in Form::handleRequest()

    @lippserd
    lippserd committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    a821a8e View commit details
    Browse the repository at this point in the history

  3. Don't always assemble in Form::handleRequest() 

    I'm not quite sure what the reasons are for the form to be assembled if
it hasn't been sent, but since elements should take care of themselves
when they need to be assembled, I'm removing that.
    @lippserd
    lippserd committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    5300da6 View commit details
    Browse the repository at this point in the history

  4. Remove event Form::ON_REQUEST

    @lippserd
    lippserd committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    3c529ce View commit details
    Browse the repository at this point in the history

  5. Remove Form::setRequest() 

    The only way to pass a request should be handleRequest().
    @lippserd
    lippserd committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    656c653 View commit details
    Browse the repository at this point in the history

  6. Respect submit elements in Form::remove()

    @lippserd
    lippserd committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    11d5015 View commit details
    Browse the repository at this point in the history

  7. Remove redirect URL from Form 

    Redirecting is not the responsibility of the form, but of the
controller.
    @lippserd
    lippserd committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    205b260 View commit details
    Browse the repository at this point in the history

  8. Deprecate Form::onSubmit() and ::ON_SUBMIT

    @lippserd
    lippserd committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    6b48b0d View commit details
    Browse the repository at this point in the history