Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FilterProcessor: Inject column expressions directly into filters #81

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

FilterProcessor: Inject column expressions directly into filters #81

wants to merge 1 commit into from

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Oct 12, 2022

fixes #75

@nilmerg nilmerg added the bug Something isn't working label Oct 12, 2022
@nilmerg nilmerg self-assigned this Oct 12, 2022
@cla-bot cla-bot bot added the cla/signed label Oct 12, 2022
yhabteab
yhabteab approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@yhabteab yhabteab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Column:

'duration' => new Expression('valid_to - valid_from')

Filter: https://yonas-icinga.com/icingaweb2/x509/certificates?duration=34300800&ca=no

Bildschirmfoto 2022-10-12 um 17 06 34

@nilmerg nilmerg added this to the v0.4.2 milestone Oct 13, 2022
@sukhwinder33445
Copy link
Contributor

Works for me as well. 🎉

@yhabteab yhabteab mentioned this pull request Oct 18, 2022
Merged
@nilmerg nilmerg marked this pull request as draft October 19, 2022 13:14
@nilmerg
Copy link
Member Author

nilmerg commented Oct 19, 2022

While it may work fine, it mis-uses a limitation in the ipl\Filter implementation. I won't merge this and added an alternative implementation of this workaround in x509: Icinga/icingaweb2-module-x509@d23ba86

@nilmerg nilmerg removed this from the v0.4.2 milestone Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhabteab yhabteab yhabteab approved these changes

Assignees

@nilmerg nilmerg

Labels
bug Something isn't working cla/signed
Projects
None yet
Milestone
Behavior and performance enhancements
Development

Successfully merging this pull request may close these issues.

Expression columns do not work in where clause
3 participants
@nilmerg @sukhwinder33445 @yhabteab