Port Template DAO to use PDO #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This begins the work to replace pg_* functions for database access with the modern PDO interface. We first migrate PostgreSQLTemplateDAO::GetById and GetByUserId methods. We will progressively extend PDO usage to the rest of DAOs, refactoring code as needed along the way.
Refactor common code in PostgreSQLTemplateDAO::GetById and GetByUserId to the function runSelectQuery. This leaves those functions looking similar to what they looked like before, when they used the execute function from the non-PDO code paths.
Rewrite method to use PDO prepared statements, typed binding and last id retrieval.
The check that looked up the template in the database before removing it was deleted because it was useless. The query will run, returning zero affected rows, if the template doesn't exist. From the outside, there is no change of behavior in the delete operation.
The missing PDO package in Debian is not a typo, it seems to be provided by another package. I'm removing the RHEL line because I don't have a RHEL system where I can test things, and I don't want to provide unverified commands.
We need to modify the properties in the VO class to match column names. Besides, the TemplateVO::setValues() function cannot be removed because it's declared abstract in a parent class. This should be temporary, until all DAOs use PDO.
anarute
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First steps towards adopting PDO (#513), starting with an isolated data type that's not used a lot.