Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Area DAO to use PDO #560

Merged
merged 7 commits into from
Feb 9, 2022
Merged

Port Area DAO to use PDO #560

merged 7 commits into from
Feb 9, 2022

Commits on Feb 7, 2022

  1. Remove redundant AreaDAO constructor.

    @jaragunde
    jaragunde committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    f251a93 View commit details
    Browse the repository at this point in the history

  2. Migrate AreaDAO getter operations to PDO.

    @jaragunde
    jaragunde committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    5dae0d5 View commit details
    Browse the repository at this point in the history

  3. Remove unused AreaDAO::getByName().

    @jaragunde
    jaragunde committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    9ac6514 View commit details
    Browse the repository at this point in the history

  4. Migrate AreaDAO create/update/delete operations to PDO. 

    Also remove some unnecessary checks in those operations.
    @jaragunde
    jaragunde committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    af48580 View commit details
    Browse the repository at this point in the history

  5. [#431] Fix warnings in area-related services. 

    Fixes:
* Undefined variable: string
* Undefined index: sid
    @jaragunde
    jaragunde committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    bc8dbff View commit details
    Browse the repository at this point in the history

  6. Remove commented test lines in PostgreSQLareaDAO.

    @jaragunde
    jaragunde committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    3efef68 View commit details
    Browse the repository at this point in the history

  7. Remove placeholder implementations of setValues in PDO DAOs. 

    We can replace them by a default implementation in the parent class.
This will be removed, eventually, when all children of BaseDAO use
the PDO API.
    @jaragunde
    jaragunde committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    66486a9 View commit details
    Browse the repository at this point in the history