Skip to content

Commit

Permalink
Replace GitHub link with regular feedback page
Browse files Browse the repository at this point in the history
Use the regular feedback page in the "Feedback" link in the Settings,
instead of taking users to GitHub. This is the same link that is used
in a similar functionality in the navigation bar.

It is unexpected that two similar "feedback" buttons would take the
user to two different pages. Furthermore, most users do not have a
GitHub account.
  • Loading branch information
felipeerias authored and svillar committed Dec 6, 2024
1 parent 32af1ff commit c24edf8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,8 @@ public void updateUI() {
if (mAudio != null) {
mAudio.playSound(AudioEngine.Sound.CLICK);
}
mWidgetManager.openNewTabForeground(getResources().getString(R.string.survey_link));
String uri = getResources().getString(R.string.feedback_link, BuildConfig.VERSION_NAME, DeviceType.getType());
mWidgetManager.openNewPageNoInterrupt(uri);
exitWholeSettings();
});
}
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values/non_L10n.xml
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,6 @@
<string name="keyboard_nl_NL_popup_i" translatable="false">ìíiïîįī</string>

<!-- Settings Survey link -->
<string name="survey_link" translatable="false">https://github.com/Igalia/wolvic/issues/</string>
<string name="feedback_link" translatable="false">https://wolvic.com/en/feedback/index.html?version=%1$s&amp;device=%2$d</string>

<!-- Phone UI links -->
Expand Down

0 comments on commit c24edf8

Please sign in to comment.