Skip to content

Commit

Permalink
Upgrade AGP to 8.0.2
Browse files Browse the repository at this point in the history
An R8 error stops us from upgrading to 8.1.0:
https://issuetracker.google.com/issues/277166577

Since we don't use `whenTaskAdded` anywhere, maybe it's
caused by one of our dependency

Signed-off-by: Songlin Jiang <[email protected]>
  • Loading branch information
HollowMan6 committed Nov 5, 2023
1 parent ac0f772 commit f6bb4e1
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ on:
description: 'Gradle version'
required: false
type: string
default: "7.5"
default: "8.0"

jobs:
build:
Expand Down
2 changes: 1 addition & 1 deletion app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,7 @@ dependencies {
// HVR
hvrImplementation fileTree(dir: "${project.rootDir}/third_party/hvr", include: ['*.jar'])
hvrImplementation 'com.huawei.agconnect:agconnect-core-harmony:1.1.0.300'
hvrImplementation 'com.huawei.agconnect:agconnect-core:1.6.5.300'
hvrImplementation 'com.huawei.agconnect:agconnect-core:1.9.1.301'
hvrImplementation 'com.huawei.hms:hianalytics:6.3.2.300'
hvrImplementation 'com.huawei.hms:ml-computer-voice-asr:3.1.0.300'
hvrImplementation 'com.huawei.hms:location:6.2.0.300'
Expand Down
1 change: 0 additions & 1 deletion app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
android:label="@string/app_name"
android:roundIcon="@mipmap/ic_launcher_round"
android:supportsRtl="true"
android:extractNativeLibs="true"
android:theme="@style/FxR.Dark">
<activity
android:name="com.igalia.wolvic.VRBrowserActivity"
Expand Down
4 changes: 2 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ buildscript {
classpath "com.android.tools.build:gradle:$versions.android_gradle_plugin"
classpath 'com.android.tools:r8:8.2.33'
classpath "$deps.kotlin.plugin"
classpath 'com.huawei.agconnect:agcp:1.6.5.300'
classpath 'com.huawei.agconnect:agcp:1.9.1.301'

// NOTE: Do not place your application dependencies here; they belong
// in the individual module build.gradle files
Expand All @@ -27,7 +27,7 @@ allprojects {
}
}

task clean(type: Delete) {
tasks.register("clean", Delete) {
delete rootProject.buildDir
delete "${rootDir}/third_party/wavesdk/build"
}
3 changes: 3 additions & 0 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,6 @@ android.useAndroidX=true
android.enableJetifier=true

org.gradle.warning.mode=all
android.defaults.buildfeatures.buildconfig=true
android.nonTransitiveRClass=false
android.nonFinalResIds=false
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Wed Jul 21 16:13:31 CEST 2021
distributionBase=GRADLE_USER_HOME
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.0-bin.zip
distributionPath=wrapper/dists
zipStorePath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
2 changes: 1 addition & 1 deletion versions.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ versions.atsl_runner = "1.5.2"
versions.atsl_rules = "1.5.0"
versions.atsl_junit = "1.1.5"
versions.espresso = "3.5.1"
versions.android_gradle_plugin = "7.4.2"
versions.android_gradle_plugin = "8.0.2"
versions.kotlin = "1.8.22"
versions.kotlin_coroutines = "1.7.3"
versions.snakeyaml = "2.0"
Expand Down

0 comments on commit f6bb4e1

Please sign in to comment.