Remove duplicated suggestions in awesome bar

[HollowMan6]

We now only remove duplicated suggestions based on URL, maybe later we can decide to remove those entries that only differ in 'http'/'https', or end with '/' or not

Before:

After:

[svillar]

I understand the rationale of the change but I am not sure it can be successfully resolved by filtering. For example imagine that you have a bookmark with a trailing slash and also a history entry without the slash. Then the history entry will be shown, but not the bookmark. That for me is a mistake because bookmarks must be always shown IMO.

The other comment I have is that comparing strings is normally slow, so I'd use a hash of the URL to be inserted in the Map instead of the full URL.

Last but not least, I don't think we can freely assume that we can remove insecure schemes (like http). For example I have some personal services at home that can be accessed either by http or https as I don't really care too much since they are internal services. I'd presume that is the same in corporate environments.

[HollowMan6]

I understand the rationale of the change but I am not sure it can be successfully resolved by filtering. For example imagine that you have a bookmark with a trailing slash and also a history entry without the slash. Then the history entry will be shown, but not the bookmark. That for me is a mistake because bookmarks must be always shown IMO.

The other comment I have is that comparing strings is normally slow, so I'd use a hash of the URL to be inserted in the Map instead of the full URL.

Last but not least, I don't think we can freely assume that we can remove insecure schemes (like http). For example I have some personal services at home that can be accessed either by http or https as I don't really care too much since they are internal services. I'd presume that is the same in corporate environments.

Okay, anyway we can revert back to 5929cde to make it less aggressive, and modify that so bookmarks must be always shown.

[HollowMan6]

I understand the rationale of the change but I am not sure it can be successfully resolved by filtering. For example imagine that you have a bookmark with a trailing slash and also a history entry without the slash. Then the history entry will be shown, but not the bookmark. That for me is a mistake because bookmarks must be always shown IMO.
The other comment I have is that comparing strings is normally slow, so I'd use a hash of the URL to be inserted in the Map instead of the full URL.
Last but not least, I don't think we can freely assume that we can remove insecure schemes (like http). For example I have some personal services at home that can be accessed either by http or https as I don't really care too much since they are internal services. I'd presume that is the same in corporate environments.

Okay, anyway we can revert back to 5929cde to make it less aggressive, and modify that so bookmarks must be always shown.

Reverted. We use hashSet so it's fast to check if a URL already exists. Also we sort before we remove duplication so that only those duplicated results that appear at the bottom of the list will get removed

[svillar]

This more conservative version looks more appealing to me. Thanks!