Fix disk LRU cache key formatting error #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeerias
previously requested changes
Dec 5, 2023
HollowMan6
force-pushed
the
disklrucache
branch
from
e57a0c0 to
8be0c27
Compare
svillar
requested changes
Dec 5, 2023
HollowMan6
force-pushed
the
disklrucache
branch
from
8be0c27 to
075d7b8
Compare
HollowMan6
force-pushed
the
disklrucache
branch
from
075d7b8 to
77924a2
Compare
svillar
requested changes
Dec 5, 2023
svillar
reviewed
Dec 5, 2023
We hash the key using sha-256
Fix the issue related to:
Failed to get Bitmap from DiskLruCache:keys must match regex [a-z0-9_-]{1,64}:
"https://igalia.github.io/wolvic-3D-environments/spring/spring.png"
Now we can access the external environments bitmap offline after
they have been loaded once.
Signed-off-by: Songlin Jiang <[email protected]>
HollowMan6
force-pushed
the
disklrucache
branch
from
77924a2 to
e51370e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hash the key using sha-256
Fix the issue related to:
Failed to get Bitmap from DiskLruCache:keys must match regex [a-z0-9_-]{1,64}: "https://igalia.github.io/wolvic-3D-environments/spring/spring.png"
Now we can access the external environments bitmap offline after they have been loaded once.