Clean composing text when resetting the keyboard layout #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR#1104 enabled word autocompletion in latin keyboard. However it also caused regressions like the following. Whenever there are multiple text entries in a webpage, switching between them does not clear the text used for autocompletion (the composing text) on time, meaning that the content of the newly focused entry is filled in with the text coming from the previously focused entry. A way to fix that is by clearing the composing text whenever resetKeyboardLayout is called. Fixes #1177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1104 enabled word autocompletion in latin keyboard. However it also caused regressions like the following. Whenever there are multiple text entries in a webpage, switching between them does not clear the text used for autocompletion (the composing text) on time, meaning that the content of the newly focused entry is filled in with the text coming from the previously focused entry.
A way to fix that is by clearing the composing text whenever resetKeyboardLayout is called.
Fixes #1177