Fix controllers disappearing #1197
Conversation
felipeerias
force-pushed
the
felipeerias/disappearingControllers
branch
from
9ba3d6d to
353b1fd
Compare
This fixes a bug with video websites like https://www.ixigua.com/ The following sequence of steps: - enter fullscreen mode - leave fullscreen mode - play the video left the app in an unusable state because the controllers became hidden and the user was not able to get them to appear again. The cause was that when the page first enters fullscreen mode, `NavigationBarWidget.onFullScreen` added a listener to the window which would wait for the current video to become available and would then update the UI for fullscreen mode. That listener was not being removed when the page left fullscreen mode, so when the user played the video later on, the listener would get activated and would try to transition the UI to fullscreen mode. This was leaving the app in an inconsistent state so clicks on the background were being ignored (`onWorldClick`). The fix is to ensure that the window listener is removed when the page leavs fullscreen mode. Just in case, `onWorldClick` will make the controllers visible by default. Fixes #1181
felipeerias
force-pushed
the
felipeerias/disappearingControllers
branch
from
353b1fd to
41d6bd5
Compare
There was a problem hiding this comment.
LGTM. However, I would suggest that we still merge #1192 as a root fix to have an additional layer of safety. onVideoAvailabilityChanged doesn't guarantee that we are in full-screen mode, so we should still check and make sure we are in full-screen before we call onEnterFullScreen, which can avoid further issues if later we want to reuse onFullscreenVideoWindowListener or have more branches (should be safe still even if we don't call removeWindowListener)
|
Looks great, but I am not sure if we should land this because I've been revamping the way fullscreen works (as it's very convoluted) and I don't think these fixes are needed. I'll upload it ASAP and we could decide later. |
|
See #1198 |
|
Let's close this in favour of #1198 |
This fixes a bug with video websites like https://www.ixigua.com/
The following sequence of steps:
left the app in an unusable state because the controllers became hidden and the user was not able to get them to appear again.
The cause was that when the page first enters fullscreen mode,
NavigationBarWidget.onFullScreenadded a listener to the window which would wait for the current video to become available and would then update the UI for fullscreen mode.That listener was not being removed when the page left fullscreen mode, so when the user played the video later on, the listener would get
activated and would try to transition the UI to fullscreen mode.
This was leaving the app in an inconsistent state so clicks on the
background were being ignored (
onWorldClick).The fix is to ensure that the window listener is removed when the page
leavs fullscreen mode.
Just in case,
onWorldClickwill make the controllers visible by default.Fixes #1181