Fix several issues when playing VR videos #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`enterVRVideo` will not be called again even if we switch the projection mode. So, with curved display enabled, things can still go wrong if users enter with a non-front-facing VR projection and then switch to a front-facing one. Signed-off-by: Songlin Jiang <[email protected]>
We should also take the texture scale into account to compute the actual width and height for the placement Signed-off-by: Songlin Jiang <[email protected]>
HollowMan6
force-pushed
the
fix-vr-videos
branch
from
72873e1 to
8849afa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enterVRVideowill not be called again even if we switch the projection mode. So, with curved display enabled, things can still go wrong if users enter with a non-front-facing VR projection and then switch to a front-facing one.We should also take the texture scale into account to compute the actual width and height for the placement.
Bug (notice the display density change):
com.igalia.wolvic-20240123-233607.mp4