[WebPayments] Introduce OverlayWidget & Use it by PaymentHandler #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshin-wolvic
reviewed
Dec 5, 2024
|
what should we do with #1646 then? |
svillar
reviewed
Dec 11, 2024
svillar
reviewed
Jan 13, 2025
| Context context = mWebContents.get().getTopLevelNativeWindow().getContext().get(); | ||
| final TabCompositorView compositorView = new TabCompositorView(context); | ||
| compositorView.onNativeLibraryLoaded(windowAndroid); | ||
| windowAndroid.setAnimationPlaceholderView(compositorView); |
There was a problem hiding this comment.
Can't we do this kind of things on the Chromium side? I believe we do that when we create a new Tab for example.
There was a problem hiding this comment.
I moved this logic to the Tab class, as a new static method. It's now evident that this code is identical to the Tab constructor, so we can apply some refactoring in the future.
The Tab.createNewTab is an horrible name, so suggestions are really welcome.
There was a problem hiding this comment.
Tab.getNewCompositorView or Tab.createCompositorView ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new OverlayWidget class is defined to render the payment handler WebContents instance, provided by the web engine, as a result of the call to the Payment Request API.
The tab that initiates the payment request needs to handle 2 WebContents instances, determining which one is active during the process. Hence, The OverlayWidget is implemented as modal dialog, preventing the original web-content to be updated until the payment request is completed.
The TabsWebContentObserver must implement a new WebContentsObserver method, defined to notify Wolvic that the new payment handler WebContents instance is ready.
This PR depends on the PR #143 in the Chromium backend.
This feature can be tested using the Web Payments demo at https://paymentrequest.show/demo