Reduce sensitivity required by controller trigger #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been traditionally using a high value for clicking threshold (0.91) in order not to generate false positives specially when using hand tracking. However, that does not make much sense when using physical controllers because they're very precise and false positives are not a real problem there. We can actually lower it to just 25% of the full pressed position without any accuracy loss, and indeed, the experience is much better. It's also good for a11y. Fixes #1487
javifernandez
approved these changes
Jan 15, 2025
felipeerias
previously requested changes
Jan 15, 2025
javifernandez
requested changes
Jan 15, 2025
javifernandez
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been traditionally using a high value for clicking threshold (0.91) in order not to generate false positives specially when using hand tracking. However, that does not make much sense when using physical controllers because they're very precise and false positives are not a real problem there.
We can actually lower it to just 25% of the full pressed position without any accuracy loss, and indeed, the experience is much better. It's also good for a11y.
Fixes #1487