[PicoXR] Do not use XR_FB_hand_tracking_aim #1680
Merged
+1
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This vendor extension provides very good values for aim when using hand tracking and is also able to detect some common gestures like pinching or doing a system gesture. It has never been really advertised by the runtime as supported but we knew it worked so we were using it anyway. However the behaviour in the latest versions of the OpenXR runtime from Pico has degraded a lot, to the point that is no longer able to detect those hand gestures. This means that we could only use the aim at the most. Provided our computed aim is good enough it's better to completely disable the extension for Pico. A nice side effect, is that the ray now properly originates from the hand. With the extension the ray origin was shifted upwards. Fixes #1679
|
Before and after |
felipeerias
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This vendor extension provides very good values for aim when using hand tracking and is also able to detect some common gestures like pinching or doing a system gesture. It has never been really advertised by the runtime as supported but we knew it worked so we were using it anyway.
However the behaviour in the latest versions of the OpenXR runtime from Pico has degraded a lot, to the point that is no longer able to detect those hand gestures. This means that we could only use the aim at the most. Provided our computed aim is good enough it's better to completely disable the extension for Pico.
A nice side effect, is that the ray now properly originates from the hand. With the extension the ray origin was shifted upwards.
Fixes #1679