Don't return duplicates

application/modules/user/mappers/User.php

@@ -118,7 +118,6 @@ public function getUserListByGroupId(int $groupId, int $confirmed = 0, $paginati
 
     /**
      * Get users (not all fields) by group ids. The users have to be in at least one of the groups.
-     * This will return duplicated users if a user is in multiple of the groups.
      *
      * @param int[] $groupIds array of group ids.
      * @param int $confirmed
@@ -133,7 +132,8 @@ public function getUserListByGroupIds(array $groupIds, int $confirmed = 0, $pagi
             ->from(['u' => 'users'])
             ->join(['g' => 'users_groups'], 'u.id = g.user_id', 'LEFT', ['group_id' => 'g.group_id'])
             ->where(['group_id' => $groupIds], 'or')
-            ->andWhere(['confirmed' => $confirmed]);
+            ->andWhere(['confirmed' => $confirmed])
+            ->group(['u.id']);
         if ($pagination !== null) {
             $select->limit($pagination->getLimit())
                 ->useFoundRows();

tests/modules/user/mappers/UserTest.php

@@ -71,17 +71,15 @@ public function testGetUserListByGroupIds()
         /** @var \Modules\User\Models\User[] $users */
         $users = $userMapper->getUserListByGroupIds([1, 3], 1);
         self::assertNotEmpty($users);
+        self::assertCount(2, $users);
+
         self::assertEquals(1, $users[0]->getId());
         self::assertEquals('Testuser1', $users[0]->getName());
         self::assertEquals(1, $users[0]->getConfirmed());
 
-        self::assertEquals(1, $users[1]->getId());
-        self::assertEquals('Testuser1', $users[1]->getName());
+        self::assertEquals(2, $users[1]->getId());
+        self::assertEquals('Testuser2', $users[1]->getName());
         self::assertEquals(1, $users[1]->getConfirmed());
-
-        self::assertEquals(2, $users[2]->getId());
-        self::assertEquals('Testuser2', $users[2]->getName());
-        self::assertEquals(1, $users[2]->getConfirmed());
     }
 
     /**