Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decline empty comment #1115

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Conversation

blackcoder87
Copy link
Member

@blackcoder87 blackcoder87 commented Nov 17, 2024

Description

  • Decline empty comment in article and user module.
PHP Fatal error:  Uncaught TypeError: Ilch\Comments::saveComment(): Argument #2 ($text) must be of type string, null given, called in application/modules/article/controllers/Index.php on line 157 and defined in application/libraries/Ilch/Comments.php:426
Stack trace:
#0 application/modules/article/controllers/Index.php(157): Ilch\Comments->saveComment()
#1 application/libraries/Ilch/Page.php(243): Modules\Article\Controllers\Index->showAction()
#2 application/libraries/Ilch/Page.php(137): Ilch\Page->loadController()
#3 index.php(68): Ilch\Page->loadPage()
#4 {main}
  thrown in application/libraries/Ilch/Comments.php on line 426, referer: index.php/article/index/show/id/1

PHP Fatal error:  Uncaught TypeError: Ilch\Comments::saveComment(): Argument #2 ($text) must be of type string, null given, called in application/modules/user/controllers/Profil.php on line 52 and defined in application/libraries/Ilch/Comments.php:426
Stack trace:
#0 application/modules/user/controllers/Profil.php(52): Ilch\Comments->saveComment()
#1 application/libraries/Ilch/Page.php(243): Modules\User\Controllers\Profil->indexAction()
#2 application/libraries/Ilch/Page.php(137): Ilch\Page->loadController()
#3 index.php(68): Ilch\Page->loadPage()
#4 {main}
  thrown in application/libraries/Ilch/Comments.php on line 426, referer: index.php/user/profil/index/user/1

Type of change

  • Bug fix (non-breaking change which fixes an issue)

This PR has been tested in the following browsers:

  • Chrome
  • Firefox
  • Opera
  • Edge

@blackcoder87 blackcoder87 merged commit 1fd37fb into master Nov 17, 2024
6 checks passed
@blackcoder87 blackcoder87 deleted the decline-empty-comment-article-user branch November 17, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant