Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to uninstall a system module and check module and layout key #1128

Merged
merged 4 commits into from
Dec 1, 2024

Conversation

blackcoder87
Copy link
Member

@blackcoder87 blackcoder87 commented Nov 30, 2024

Description

  • Do not try to uninstall a system module.
  • Fix error on uninstall action with invalid module key.
  • Check if layoutKey could be valid.
  • Add error messages and use correct message for uninstall.
  • Remove dead variable.
Fatal error: Uncaught Error: Class '\Modules\Aaaa\Config\Config' not found in application/modules/admin/controllers/admin/Modules.php:425

Stack trace:
#0 application/libraries/Ilch/Page.php(243): Modules\Admin\Controllers\Admin\Modules->uninstallAction()
#1 application/libraries/Ilch/Page.php(137): Ilch\Page->loadController()
#2 index.php(68): Ilch\Page->loadPage()
#3 {main}
    thrown in application/modules/admin/controllers/admin/Modules.php on line 425
PHP Fatal error:  Uncaught Error: Class "\Layouts\Layouts\Config\Config" not found in application/modules/admin/controllers/admin/Layouts.php:330
Stack trace:
#0 application/libraries/Ilch/Page.php(243): Modules\Admin\Controllers\Admin\Layouts->advSettingsShowAction()
#1 application/libraries/Ilch/Page.php(137): Ilch\Page->loadController()
#2 index.php(68): Ilch\Page->loadPage()
#3 {main}
  thrown in application/modules/admin/controllers/admin/Layouts.php on line 330

ToDo:

  • ...

Type of change

  • Bug fix (non-breaking change which fixes an issue)

This PR has been tested in the following browsers:

  • Chrome
  • Firefox
  • Opera
  • Edge

@blackcoder87 blackcoder87 marked this pull request as draft November 30, 2024 16:15
@blackcoder87 blackcoder87 changed the title Do not try to uninstall a system module Do not try to uninstall a system module and check module and layout key Nov 30, 2024
@blackcoder87 blackcoder87 marked this pull request as ready for review December 1, 2024 06:44
@blackcoder87 blackcoder87 merged commit f10db82 into master Dec 1, 2024
6 checks passed
@blackcoder87 blackcoder87 deleted the do-not-try-to-uninstall-system-module branch December 1, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant