Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Away: Allow editing of own entries #1138

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

blackcoder87
Copy link
Member

Description

  • Allow editing of own entries.
  • Code improvements.
  • Fix issue with a previous change (invalid class name).

Fixes #781

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

This PR has been tested in the following browsers:

  • Chrome
  • Firefox
  • Opera
  • Edge

@hhunderter
Copy link
Member

https://github.com/IlchCMS/Ilch-2.0/pull/1138/files#diff-682c474ace0388d75abaaea883e5eb0a5c9e25cab39f97231155ffdcc71d0038R94

$userGroups = $awayGroupMapper->getGroups();
$users = $userMapper->getUserListByGroupId($userGroups, 1);

Expected parameter of type 'int', 'array|null' provided

hab zwar keinen Fehler bekommen aber sollten wir aufn Schirm behalten?

@blackcoder87 blackcoder87 merged commit e4ec70d into master Dec 18, 2024
6 checks passed
@blackcoder87 blackcoder87 deleted the away-module-issue781-edit-entry branch December 18, 2024 15:09
@blackcoder87
Copy link
Member Author

#1145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Away module: Add feature to edit away entry
2 participants