Upcoming events page #338
Open
Upcoming events page #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inolasv
requested changes
Nov 21, 2024
There was a problem hiding this comment.
Great start! I made a few comments (most are trivial) on the code itself, but one thing i wanted to bring up was that maybe we can anchor some parts of the events to sides of the box to keep consistent padding. I know this might be a lot so let me know if you have any questions about anything!
what we currently have
what we want
| } | ||
|
|
||
| .window { | ||
| position: absolute; | ||
| z-index: 99; | ||
| /* position: absolute; | ||
| top: 50%; | ||
| left: 50%; |
There was a problem hiding this comment.
yeah i see all of this is commented out, was there a resason for hat?
There was a problem hiding this comment.
I believe they either did not affect the output visually, but I can confirm this later when events are displayed on the website again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status:
Description
I edited the upcoming events page to make the modals structured properly and of a proper size. I made the dates and day of week formatted properly.
Screenshots