Neater UI #188
Neater UI #188
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
==========================================
- Coverage 80.23% 80.16% -0.07%
==========================================
Files 28 28
Lines 344 353 +9
==========================================
+ Hits 276 283 +7
- Misses 68 70 +2 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Thanks @cvzbynek. What a make over! Looks great. I've made a few comments where I things an be tidied up a bit. Could you also take a pass at the alignment of content in the table columns? Whilst the left align works well for the UUID column I think the others would benefit from having their headers and content centered.
process_manager/templates/process_manager/partials/message_items.html
Outdated
Show resolved
Hide resolved
process_manager/templates/process_manager/partials/process_table.html
Outdated
Show resolved
Hide resolved
process_manager/views/pages.py
Outdated
| # Process the log text to exclude empty lines | ||
| log_lines = [val.data.line for val in logs_response if val.data.line.strip()] | ||
|
|
||
| context = {"log_lines": log_lines, "log_text": "\n".join(log_lines)} |
There was a problem hiding this comment.
Seems log_text is no longer used in the template context and can be removed.
There was a problem hiding this comment.
log_lines gives more granular control for rendering each line, while log_text maintains compatibility with existing tests and code until it's fully transitioned to use log_lines.
There was a problem hiding this comment.
The only other place that seems to use log_text is the test. So I think we should remove it and update the test to reflect that.
There was a problem hiding this comment.
Ok, I'll remove it. Can you update the test? After you do it,I'll make a final (I hope) comit
There was a problem hiding this comment.
You can probably bundle it it's a simple change here to swap log_text for log_lines -
|
We have #192 which is based against this branch so I'm going to merge that in here before merging this into main. |
Adds Time info to message feed header
| #message-list { | ||
| max-height: 80vh; | ||
| overflow-y: auto; | ||
| } | ||
| .table-container { |
There was a problem hiding this comment.
There is a lot of extra css in this PR, and it's all put into the index page for the process_manager. Would it be better off that it is moved to the base.html so all the pages (in both the process_manager and the controller) inherit the same css adjustments?
Description
This PR improves the user interface for the process manager page, introducing several enhancements for a more polished, functional layout:
Fixes #170
Type of change
Key checklist
python -m pytest)python -m sphinx -b html docs docs/build)pre-commit run --all-files)Further checks