Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State machine #213

Merged
merged 104 commits into from
Dec 10, 2024
Merged

State machine #213

merged 104 commits into from
Dec 10, 2024

Conversation

dalonsoa
Copy link
Collaborator

@dalonsoa dalonsoa commented Nov 6, 2024

Description

This PR implements the proof of concept of the state machine view.

Currently, the state machine can only go from initial to configured and back. Running start requires to pass arguments to the command, which is implemented in #227

Fixes #215
Partly addresses #217

Recording.2024-11-20.062818.mp4

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 94.82759% with 9 lines in your changes missing coverage. Please review.

Project coverage is 86.03%. Comparing base (5838bb5) to head (3e070a7).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
process_manager/process_manager_interface.py 16.66% 5 Missing ⚠️
controller/views/partials.py 93.54% 2 Missing ⚠️
controller/controller_interface.py 97.91% 1 Missing ⚠️
controller/views/pages.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   82.39%   86.03%   +3.63%     
==========================================
  Files          33       38       +5     
  Lines         409      580     +171     
==========================================
+ Hits          337      499     +162     
- Misses         72       81       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cc-a cc-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a nice start to things.

controller/fsm.py Outdated Show resolved Hide resolved
@dalonsoa dalonsoa marked this pull request as ready for review November 12, 2024 11:33
@dalonsoa dalonsoa requested a review from cc-a November 12, 2024 11:36
@dalonsoa dalonsoa changed the title WIP: State machine State machine front end Nov 12, 2024
@jamesturner246 jamesturner246 mentioned this pull request Dec 9, 2024
11 tasks
@cc-a cc-a enabled auto-merge December 10, 2024 12:49
@cc-a cc-a merged commit 249616f into main Dec 10, 2024
4 checks passed
@cc-a cc-a deleted the state_machine branch December 10, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement simple, clickable representation of the FSM
5 participants