Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the general view of the application tree via a table #232

Open
wants to merge 4 commits into
base: app-tree
Choose a base branch
from

Conversation

dalonsoa
Copy link
Collaborator

@dalonsoa dalonsoa commented Nov 13, 2024

Description

Not super visually appealing, and not collapsible, as discussed in #230 , but showing everything that should be there. It can be accessed by clicking in the header of the app tree, in the controller overview page.

Recording.2024-11-13.134051.mp4

Fixes #230

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@dalonsoa dalonsoa changed the base branch from main to app-tree November 13, 2024 13:54
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.84%. Comparing base (19b3c5f) to head (432589d).

Files with missing lines Patch % Lines
controller/views/pages.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           app-tree     #232      +/-   ##
============================================
+ Coverage     85.46%   85.84%   +0.37%     
============================================
  Files            36       36              
  Lines           523      544      +21     
============================================
+ Hits            447      467      +20     
- Misses           76       77       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement front end for application tree using a table
2 participants