Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build test_data into Docker image #60

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Build test_data into Docker image #60

merged 2 commits into from
Aug 13, 2024

Conversation

J4bbi
Copy link
Collaborator

@J4bbi J4bbi commented Aug 12, 2024

  • Issue: [Link to the issue. Do not use any of the github automation keywords]

This PR copies the test_data into the Docker image so that it can be run in the container by the Invenio user.

Developer Checklist

Developers should review and confirm each of these items before requesting review

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Code documentation and related non-code documentation has all been updated

Reviewer Checklist

Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section can be duplicated for each reviewer

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Code documentation and related non-code documentation has all been updated
  • Migation has been created and tested

Testing

List user test scripts that need to be run

List any non-unit test scripts that need to be run

@cc-a
Copy link
Collaborator

cc-a commented Aug 12, 2024

Ready for review @J4bbi?

@J4bbi
Copy link
Collaborator Author

J4bbi commented Aug 12, 2024

Ready for review @J4bbi?

Yeah, go ahead. Thanks

@cc-a cc-a self-requested a review August 12, 2024 11:32
Copy link
Collaborator

@cc-a cc-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense but I think it would be better to have invenio rather than 1000 as this is likely to be more robust to changes in the upstream image.

@cc-a cc-a merged commit e33fba8 into develop Aug 13, 2024
2 checks passed
@cc-a cc-a deleted the fix/test-data-docker branch August 13, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants