Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve metadata mapping for example datasets #63

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

cc-a
Copy link
Collaborator

@cc-a cc-a commented Aug 20, 2024


This is a revisit of the issue that improves the mapping between the source datacite schema and the invenio rdm schema by:

  • Adding license metadata (rights)
  • Date metadata
  • Previously some datacite related identifiers were being mapped into the references section of the invenio schema. Update here so that these are now related identifiers under the invenio schema as well.

Developer Checklist

Developers should review and confirm each of these items before requesting review

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Code documentation and related non-code documentation has all been updated

Reviewer Checklist

Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section can be duplicated for each reviewer

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Code documentation and related non-code documentation has all been updated
  • Migation has been created and tested

Testing

List user test scripts that need to be run

List any non-unit test scripts that need to be run

Copy link
Collaborator

@Steven-Eardley Steven-Eardley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@cc-a cc-a merged commit b6c1a5d into develop Aug 21, 2024
2 checks passed
@cc-a cc-a deleted the feature/better-test-metadata branch August 21, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants