Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CachedRef borrowing #215

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tynberry
Copy link

When using CachedRef one had to pass a closure or a function that takes the mutable reference to the component and returns something. This limits ergonomics as one has to either extract fields from the component, possibly requiring to clone them which might be expensive or move their entire code into the closure.

This adds borrow_mut and try_borrow_mut methods which return a mutable reference to the component (returning an immutable reference is useless as it would not make the method &self instead of &mut self).

If there are any unsoudness issues with this approach, notice me, this is my first time contributing to Flecs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant