Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using CachedRef one had to pass a closure or a function that takes the mutable reference to the component and returns something. This limits ergonomics as one has to either extract fields from the component, possibly requiring to clone them which might be expensive or move their entire code into the closure.
This adds
borrow_mut
andtry_borrow_mut
methods which return a mutable reference to the component (returning an immutable reference is useless as it would not make the method &self instead of &mut self).If there are any unsoudness issues with this approach, notice me, this is my first time contributing to Flecs.