Adapting timeout while-loop in Wire.cpp #317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frederik-Wagner
force-pushed
the
bugfix/timeout
branch
from
79f6158 to
038e7f7
Compare
|
@OlafFilies will check if we can run the HIL tests in this PR and @LinjingZhang & @jaenrig-ifx will peer-review. |
jaenrig-ifx
reviewed
Dec 2, 2024
libraries/Wire/src/Wire.cpp
Outdated
| delay(1); | ||
| timeout--; | ||
| if (timeout == 0) { | ||
| Serial.println("Warning Timeout"); |
There was a problem hiding this comment.
We are not using stdout errors/warning here in this class (anywhere else) or? so to keep in consistent let´s remove the Serial.println("Warning Timeout");
LinjingZhang
reviewed
Dec 3, 2024
Frederik-Wagner
force-pushed
the
bugfix/timeout
branch
from
038e7f7 to
85007b6
Compare
Frederik-Wagner
force-pushed
the
bugfix/timeout
branch
from
85007b6 to
6c5d2bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error: Wire.cpp got stocked in the while-loop for the timeout since the timeout-condition was not defined as it should be per definition. It was not possible to leave the while-loop after the timeout-variable reached 0.
Change: Now, the checking condition was reduced to the essentials (it was wrong before) and another if-condition, which checks if the timeout-variable reached 0, was added inside the while-loop. This leads to a break.
Testing: The new wire.cpp was tested with the KIT_XMC_2GO_XMC1100_V1 & KIT_XMC47_RELAX_LITE_V1. Both worked.