Bugfix/desmakers 4270 serial.print is not allways working correctly in xmc for arduino version 3.5.0 #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A HIL Hub in MUC lab can't switch port on and off automatically. Not yet solved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Removed the transmit ringbuffer in order to quickly fix this Serial.print().
More changes will be made when replace coreAPI.
Related Issue
Please check DESMAKERS 4270
Context
For UART transmission, the original XMC4Arduino implementation was very confusing. Although our XMC USIC already comes with a hardware buffer and the xmclib API has a wait feature to block tx, we also use an additional software Ringbuffer. So We remove the ringbuffer and simply use the XMC_UART_CH_Transmit API (When FIFO is not configured, the API waits for the TBUF to be available. This makes the execution a blocking call).