Quick base branch change #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, it was possible to have this sequence: - A commit is pushed, workflow is started - The base branch is changed within a few seconds, another workflow is started - Both workflows finally get to run, but since they both fetch the base branch from the API, they both check the same thing. This commit fixes that by propagating the event info that triggered the workflow into the script
Before it was possible to get this sequence: - A commit is pushed, workflow is being started - Another commit is pushed within a couple seconds, another workflow is being started - Both workflows now check the state of the base branch, running the same check twice since the base branch points at the same commit This fixes that problem by making it use the Git hash that actually triggered the event.
|
The PR's base branch is set to staging, but 1 commits from the master branch are included. Make sure you know the right base branch for your changes, then:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.