test

Infisical · Oct 18, 2024 · de1cd8b · de1cd8b
1 parent d63c793
commit de1cd8b
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/backend/src/ee/services/access-approval-policy/access-approval-policy-service.ts b/backend/src/ee/services/access-approval-policy/access-approval-policy-service.ts
@@ -43,6 +43,14 @@ export const accessApprovalPolicyServiceFactory = ({
   projectDAL,
   userDAL
 }: TSecretApprovalPolicyServiceFactoryDep) => {
+  const $getGroupsUsers = async (groupIds: string[], orgId: string) => {
+    const usersPromises = await Promise.all(
+      groupIds.map((groupId) => groupDAL.findAllGroupPossibleMembers({ orgId, groupId, offset: 0 }))
+    );
+
+    return usersPromises.map((group) => group.members).flat();
+  };
+
   const createAccessApprovalPolicy = async ({
     name,
     actor,
@@ -110,21 +118,13 @@ export const accessApprovalPolicyServiceFactory = ({
       approverUserIds = approverUserIds.concat(approverUsers.map((user) => user.id));
     }
 
-    const test: number = "test";
-
-    const usersPromises: any[] = [];
-    // await Promise.all(
-    //       groupApprovers.map((groupId) => groupDAL.findAllGroupPossibleMembers({ orgId: actorOrgId, groupId, offset: 0 }))
-    //     )
     const verifyAllApprovers = [...approverUserIds];
 
     // for (const groupId of groupApprovers) {
     //   const userPromise =        ;
     //   usersPromises.push(userPromise);
     // }
-    const verifyGroupApprovers = usersPromises
-      .map((group) => group.members)
-      .flat()
+    const verifyGroupApprovers = (await $getGroupsUsers(groupApprovers, actorOrgId))
       .filter((user) => user.isPartOfGroup)
       .map((user) => user.id);
     verifyAllApprovers.push(...verifyGroupApprovers);