Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Test Connection capability and User Search Filter for LDAP configuration #1733

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Add Test Connection capability and User Search Filter for LDAP configuration #1733

merged 5 commits into from
Apr 25, 2024

Conversation

dangtony98
Copy link
Collaborator

@dangtony98 dangtony98 commented Apr 25, 2024 •
edited
Loading

Description 📣

This PR contains a few items:

  • Test connection capability that performs a bind operation against the LDAP server using the given URL, Bind DN, and Bind Pass; this is a sanity check for part of the LDAP configuration.
  • New searchFilter field onto the LDAP configuration options to increase flexibility of the configuration in terms of which users the LDAP query should consider.
  • LDAP filter validation.
  • Documentation for the test connection capability and searchFilter field.

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

maidul98
maidul98 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maidul98 maidul98 merged commit 6da5f12 into main Apr 25, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maidul98 maidul98 maidul98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dangtony98 @maidul98