Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added secret expand option in secrets get API #1781

Merged
merged 2 commits into from
May 5, 2024
Merged

feat: added secret expand option in secrets get API #1781

merged 2 commits into from
May 5, 2024

Conversation

sheensantoscapadngan
Copy link
Member

@sheensantoscapadngan sheensantoscapadngan commented May 4, 2024 •
edited
Loading

Description 📣

  • raw secrets can now be expanded in the server-side

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

maidul98
maidul98 requested changes May 5, 2024
View reviewed changes
Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I also tested it on my end and it works as expected. Left one comment about field name

backend/src/server/routes/v3/secret-router.ts Outdated Show resolved Hide resolved
@maidul98 maidul98 merged commit b4f1bec into main May 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maidul98 maidul98 maidul98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheensantoscapadngan @maidul98