CreateJunctionTable checks for table and optional foreign key and better error handling #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed better error handling in db/utils
akhilmhdh
requested changes
Aug 16, 2024
|
@Ayush-Dutt-Sharma please remove the consoles also. Its not needed as i told knex providers a pretty elaborate error message when failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
Fixed --> Function CreateJunctionTable is not checking, if the table already exists or not #2277
Condition to check for existing table
Conditional Indexing on Foreign key
Added better Error Handling
Type ✨
[ ✅] Bug fix
[ ✅] I have read the contributing guide, agreed and acknowledged the code of conduct. 📝