Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bulk save secrets #2294

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: bulk save secrets #2294

wants to merge 5 commits into from

Conversation

Utkarshn10
Copy link

@Utkarshn10 Utkarshn10 commented Aug 15, 2024 •
edited
Loading

Description 📣

Solves #2031

This PR adds the feature to bulk update secrets. To solve the issue I have used the prop drilling method and have sent setBulkSecretUpdateContent array state and updating it when a secret is updated, deleted or added.

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

Edge cases Tested:

  1. Updating secrets under a single secretname
  2. Updating and saving secrets under multiple secretnames
  3. Updating a secret and then deleting the secret using already existing delete functionality (in this case the secret should also be removed from the array that contains the updated secrets)
  4. Create a folder and then update the secrets
REC-20240815181013.mp4

@Utkarshn10 Utkarshn10 changed the title Feat bulk save secrets feat: bulk save secrets Aug 15, 2024
@Utkarshn10
Copy link
Author

Utkarshn10 commented Aug 24, 2024 •
edited
Loading

@vmatsiiako, could you please review this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Utkarshn10