🐛 — Fetch all Gitlab groups of user #2413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldidry
force-pushed
the
fetch-all-gitlab-groups
branch
from
a7f0ca2
to
c475731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
The Gitlab integration only fetched the first page of user’s groups. This PR makes it fetch all the user’s groups.
Note: I choosed to fetch 10 groups per page as the project fetching code, which I just adapted, was using a pagination of 10 projects per page.
Type ✨
Tests 🛠️
Steps to reproduce
Test
I recompiled Infisical with my patch and it works, I can now see all my groups.