fix: allow creation of multiple project envs #2514
Open
+133
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maidul98
reviewed
Oct 1, 2024
| try { | ||
| if (!lock) { | ||
| await keyStore.waitTillReady({ | ||
| key: `${KeyStorePrefixes.WaitUntilReadyCreateProjectEnvironment}${projectId}`, |
There was a problem hiding this comment.
We should have used a function for this key name because right now the next person will have to remembert to append the project id on it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
Previously when creating multiple project environments at once, it was possible that our database would throw an error, due to the unique composite constraint on project ID / position. This would happen because the transactions would turn into race conditions of whichever would first finish wish the selected position.
The solution for this is to use the keystore to ensure that only one project environment update / create / delete operation will run at once.
Type ✨