Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: github integration with Github app auth #2566

Merged
merged 13 commits into from
Oct 16, 2024

Conversation

sheensantoscapadngan
Copy link
Member

@sheensantoscapadngan sheensantoscapadngan commented Oct 9, 2024

Description 📣

This PR will allow users to setup integration with Github via app authorization. This will allow the creation of a native integration where the access scope is limited only to secret-related permissions. With app authorization, the github integration won't be linked to a specific github user, unlike Oauth.

image image

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@sheensantoscapadngan sheensantoscapadngan marked this pull request as ready for review October 14, 2024 11:27
@sheensantoscapadngan sheensantoscapadngan changed the title WIP feat: github integration with Github app auth feat: github integration with Github app auth Oct 15, 2024
Copy link
Contributor

@scott-ray-wilson scott-ray-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good other than a few things pointed out below. Using previous OAuth version of GitHub integration also worked as expected

backend/src/lib/config/env.ts Outdated Show resolved Hide resolved
docs/integrations/cicd/githubactions.mdx Outdated Show resolved Hide resolved
@sheensantoscapadngan sheensantoscapadngan merged commit c47e0d6 into main Oct 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants