-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: github integration with Github app auth #2566
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheensantoscapadngan
changed the title
WIP feat: github integration with Github app auth
feat: github integration with Github app auth
Oct 15, 2024
scott-ray-wilson
requested changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good other than a few things pointed out below. Using previous OAuth version of GitHub integration also worked as expected
backend/src/services/integration-auth/integration-auth-service.ts
Outdated
Show resolved
Hide resolved
backend/src/services/integration-auth/integration-sync-secret.ts
Outdated
Show resolved
Hide resolved
…ion of github connections
scott-ray-wilson
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR will allow users to setup integration with Github via app authorization. This will allow the creation of a native integration where the access scope is limited only to secret-related permissions. With app authorization, the github integration won't be linked to a specific github user, unlike Oauth.
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets