feat: secret reference graph for understanding how its pulled #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge this until permission v2 is merged |
scott-ray-wilson
requested changes
Oct 17, 2024
There was a problem hiding this comment.
As a general comment on the PR - this new reference tree addition is awesome but I don't think users should have to navigate to this view to see the expanded secret value.
This should be visible from the table itself (both overview and main pages), maybe a hover or button as mentioned here
frontend/src/views/SecretMainPage/components/SecretListView/SecretReferenceDetails.tsx
Outdated
Show resolved
Hide resolved
frontend/src/views/SecretMainPage/components/SecretListView/SecretReferenceDetails.tsx
Outdated
Show resolved
Hide resolved
|
@scott-ray-wilson We don't want to show the entire tree on hover and next issue with hover is what about when they type, and all other cases it will popup. Second thing is i don't want to fill any more button on main page rows. It's already too much. Correction: I have decided to make that dashboard to dropdown and move some icons to there. |
akhilmhdh
force-pushed
the
feat/secret-reference-path-way
branch
from
da872e6
to
4c07716
Compare
|
Update screenshot |
…to better graph structure
akhilmhdh
force-pushed
the
feat/secret-reference-path-way
branch
from
4c07716
to
b9a1629
Compare
scott-ray-wilson
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR introduces a secret reference details window in detail side bar. This helpers user to see the original value and also a graph view inference made to pull the reference.
The function is attached to the original function so that both are kept in sync. The next thing is tracing is optional inside the function so that most of other the time expansion happens its not done
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets