Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: static ldap credentials #2641

Merged
merged 4 commits into from
Nov 10, 2024

Conversation

sheensantoscapadngan
Copy link
Member

@sheensantoscapadngan sheensantoscapadngan commented Oct 23, 2024

Description 📣

This PR will allow users to manage static LDAP credentials via dynamic secrets
image

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@maidul98 maidul98 changed the title feat: initial schema setup feat: static ldap secrets Oct 23, 2024
@sheensantoscapadngan sheensantoscapadngan marked this pull request as ready for review October 24, 2024 13:30
@sheensantoscapadngan sheensantoscapadngan changed the title feat: static ldap secrets feat: static ldap credentials Oct 24, 2024
Copy link
Contributor

@DanielHougaard DanielHougaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@sheensantoscapadngan sheensantoscapadngan merged commit d80a707 into main Nov 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants