-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add queryRows function #209
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 89.71% 89.78% +0.06%
==========================================
Files 18 18
Lines 963 979 +16
Branches 150 151 +1
==========================================
+ Hits 864 879 +15
- Misses 39 40 +1
Partials 60 60 ☔ View full report in Codecov by Sentry. |
@bednar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added comments requesting a few changes. The ones that I might insist upon are related to examples in javadoc comments, which seem to not show the method being documented. or otherwise appear to be broken.
It would be nice to extend testing.
- One or two unit tests for new methods would be nice
- The integration test could be more complete
- When testing integration it would be nice to test a couple of basic handled exceptional situations.
src/main/java/com/influxdb/v3/client/internal/VectorSchemaRootConverter.java
Show resolved
Hide resolved
@karel-rehor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some issues with the Javadoc examples. The arguments in many of the examples do not match the method they are documenting. Also, when looking at how the javadoc is rendered in Intellij, the formatting of the examples could be improved to be more easily readable.
Hi @karel-rehor |
Closes #33
Proposed Changes
Add queryRows, which return row as a Map
Checklist